[docker] consolidate dockerfiles#1007
Open
fdupress wants to merge 1 commit into
Open
Conversation
fdupress
added
the
chore
Member
Author
|
Converting to draft again, I think I want to also separate To be discussed briefly. |
fdupress
force-pushed
the
docker-consolidate
branch
from
58554e6 to
58d208a
Compare
fdupress
force-pushed
the
docker-consolidate
branch
from
58d208a to
a26cd8b
Compare
This allows us to parameterise later layers on earlier ones. In practice, I want to use this to avoid rebuilding the `base` layer in PR and merge queue runs, building it only on `main` and release branches and tags. As a drive-by bonus, this means we can cache the `base` and `build` layers for reuse when building the `test` layer. I've also added a hook to allow building from a local working copy. (By providing an EC_REPO argument when building the `test` target.) This should allow us to pre-build the test image once and for all for all post-build checks. (Using `.` as EC_REPO, perhaps—haven't really thought that far.)
fdupress
force-pushed
the
docker-consolidate
branch
from
a26cd8b to
7019e6d
Compare
Member
Author
|
@strub this is now ready for review. It is only a refactor, which should not change any measurable behaviour (including on build time), but gives us the flexibility to change measurable behaviour later down the line. (In practice, a build of the See #1008 to see how I intend to use this to shortcut the PR builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to parameterise later layers on earlier ones.
In practice, I want to use this to avoid rebuilding the
baselayer in PR and merge queue runs, building it only onmainand release branches and tags. As a drive-by bonus, this means we can cache thebaseandbuildlayers for reuse when building thetestlayer.I've also added a hook to allow building from a local working copy. (By providing an EC_REPO argument when building the
testtarget.) This should allow us to pre-build the test image once and for all for all post-build checks. (Using.as EC_REPO, perhaps—haven't really thought that far.)